Add commit tests #768
Merged
Add commit tests #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{craft}
extensions: curl,ast
sapi: cli,micro
{/craft}
{craft}
extensions: curl,ast
sapi: cli,micro
{/craft}
{craft}
extensions: curl,ast
sapi: cli,micro
{/craft}
{craft}
extensions: curl,ast
sapi: cli,micro
{/craft}
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces default handling for shared extensions, updates documentation to reflect the new option, and adds a GitHub Actions workflow to parse commit message tags and run craft/bash tests automatically.
- Provide an empty-array default for
shared-extensionsinCraftCommand - Document the
shared-extensionskey underbuild-options - Add
.github/workflows/commit-tests.ymlto conditionally run tests based on{craft}and{bash}tags
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SPC/command/CraftCommand.php | Default missing shared-extensions to an empty array |
| docs/deps-craft-yml.md | Add shared-extensions: [] sample under build-options |
| .github/workflows/commit-tests.yml | New workflow to parse commit tags and run craft/bash tests |
Comments suppressed due to low confidence (6)
src/SPC/command/CraftCommand.php:52
- Add or update unit/integration tests to cover the scenario when
shared-extensionsis not provided, ensuring that the default empty array case behaves as expected.
$shared_extensions = implode(',', $craft['shared-extensions'] ?? []);
docs/deps-craft-yml.md:45
- Indent this comment line and the following key so they correctly appear under the
build-optionsblock with the same two-space indentation as the other YAML entries.
# Build options for shared extensions (same as `build-shared` command options, all options are optional)
.github/workflows/commit-tests.yml:35
- This
exit 0halts the entire parsing script when{craft}tags are missing, preventing downstream parsing of Bash tags or prefix/OS settings. Consider removing or replacing it to allow the script to continue processing.
exit 0
.github/workflows/commit-tests.yml:36
- Explicitly set
skip_craft=nowhen craft tags are found to make the workflow logic clearer and avoid relying on an empty default.
else
.github/workflows/commit-tests.yml:51
- In the Bash parsing block, explicitly set
skip_bash=nowhen{bash}tags are found to make the condition more transparent.
else
.github/workflows/commit-tests.yml:1
- [nitpick] The workflow
nameisSingle Testbut it runs both craft and bash jobs. Consider renaming it to something likeCommit Teststo better reflect its purpose.
name: Single Test
henderkes
requested changes
Jun 14, 2025
{craft}
extensions: bcmath
shared-extensions: xdebug,swoole
sapi: cli
{/craft}
[spc_prefix:bin/spc-gnu-docker]
crazywhalecc
force-pushed
the
ci/commit-tests
branch
from
2a1e1b6 to
0e88cdb
Compare
Collaborator
|
I'm on a short weekend trip, I can leave a proper review tomorrow evening |
Owner
Author
Ah no problem. I'll leave tomorrow, too. Enjoy your weekend! |
henderkes
reviewed
Jun 16, 2025
Owner
Author
|
Looks good to me now. I also updated the PR template. |
henderkes
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist before merging
*.php, runcomposer cs-fixat local machine.src/global/test-extensions.php../docs/.config/xxx.jsoncontent, runbin/spc dev:sort-config xxx.